This repository has been archived by the owner on Aug 5, 2021. It is now read-only.
Adding How to Inventory Code menu option under Federal Agencies #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've pulled the branch and test locally. No errors during the tests. The error that showed up in the CircleCI build is not related to the tests themselves. In fact, the test threw the error correctly. The issue has to do with the use of the API key being blocked/denied access. The key is present in three files:
The keys are blocked by IP/domain so they are "safe". That being said they should be removed and our tests should probably be changed to not depend on our API. @DanielJDufour I'll be creating some issues to remove these and rethink how we are doing our tests. |
|
Awesome. Great PR! Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jlow81 per our conversation yesterday, I'm adding the "How to Inventory Code" menu option as the first option on the Federal Agencies submenu list. The menu option is hyperlinked to the Metadata Schema 2.0.0 requirements.
See demo:
https://files.fm/u/6des9n7g#/view/how-to-inventory-code.png
@DanielJDufour or @froi please review PR.
thanks,
Ricardo